From 0d47f1ae7cc12e7043535acee2d05db75bd31574 Mon Sep 17 00:00:00 2001
From: "Samuele E. Locatelli (W11-AI)" <samuele.locatelli@egalware.com>
Date: Wed, 18 Mar 2026 12:58:21 +0100
Subject: [PATCH] Correzioni minori update OfferRow

---
 .../Services/Sales/OfferRowService.cs         | 23 +++++++++----------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/EgwCoreLib.Lux.Data/Services/Sales/OfferRowService.cs b/EgwCoreLib.Lux.Data/Services/Sales/OfferRowService.cs
index 7c1e3a91..474bd731 100644
--- a/EgwCoreLib.Lux.Data/Services/Sales/OfferRowService.cs
+++ b/EgwCoreLib.Lux.Data/Services/Sales/OfferRowService.cs
@@ -59,26 +59,21 @@ namespace EgwCoreLib.Lux.Data.Services.Sales
         {
             return await TraceAsync($"{_className}.FixUid", async (activity) =>
             {
-                List<string> result = new List<string>();
-
-                // 1. Recupero righe
                 var rows = await _repo.GetByParentAsync(offerId);
-                if (rows == null)
-                    return result;
 
                 // 2. Trovo quelle da sistemare
                 var list2fix = rows
                     .Where(x => string.IsNullOrEmpty(x.OfferRowUID) || x.OfferRowUID != x.OfferRowDtx)
                     .ToList();
 
-                // 3. Se non c’è nulla da fare → ritorno
+                // 3. Se non c'è nulla da fare → ritorno
                 if (list2fix.Count == 0)
-                    return result;
+                    return new List<string>();
 
                 // 4. Preparo la lista da restituire
-                result = list2fix
+                var result = list2fix
                             .Select(x => x.OfferRowDtx)
-                            .ToList() ?? new List<string>();
+                            .ToList();
 
                 // 5. Aggiorno i record
                 foreach (var row in list2fix)
@@ -115,9 +110,9 @@ namespace EgwCoreLib.Lux.Data.Services.Sales
                     .Where(x => x.ImgType == ImageType.ND)
                     .ToList();
 
-                // 3. Se non c’è nulla da fare → ritorno
+                // 3. Se non c'è nulla da fare → ritorno (nessun cambio necessario)
                 if (list2fix.Count == 0)
-                    return false;
+                    return true;
 
 
                 // 5. Aggiorno i record
@@ -127,7 +122,7 @@ namespace EgwCoreLib.Lux.Data.Services.Sales
                     if (row.SellingItemNav != null && (row.SellingItemNav.SourceType == ItemSourceType.Jwd || row.SellingItemNav.SourceType == ItemSourceType.FileBTL))
                     {
                         row.ImgType = ImageType.Calculated;
-                    }
+        }
                 }
 
                 // 6. Salvo
@@ -228,6 +223,7 @@ namespace EgwCoreLib.Lux.Data.Services.Sales
                 currRec.FileResource = updRec.FileResource;
                 currRec.FileSize = updRec.FileSize;
                 currRec.SerStruct = updRec.SerStruct;
+                currRec.ImgType = Core.Enums.ImageType.Calculated;
 
                 activity?.SetTag("db.operation", "UPDATE");
 
@@ -310,6 +306,7 @@ namespace EgwCoreLib.Lux.Data.Services.Sales
                     return false;
 
                 currRec.SerStruct = serStruct;
+                currRec.ImgType = Core.Enums.ImageType.Calculated;
 
                 activity?.SetTag("db.operation", "UPDATE");
 
@@ -347,6 +344,8 @@ namespace EgwCoreLib.Lux.Data.Services.Sales
                 {
                     operation = "INSERT";
                     success = await _repo.AddAsync(upsRec);
+                    
+                    if (!success) return null;  // Return null on insert failure
                 }
 
                 activity?.SetTag("db.operation", operation);