Code cleanup con CodeMaid
This commit is contained in:
Samuele E. Locatelli
@@ -17,55 +17,55 @@ import modifiers from '../modifiers/index';
|
||||
* @memberof Popper
|
||||
*/
|
||||
export default {
|
||||
/**
|
||||
* Popper's placement.
|
||||
* @prop {Popper.placements} placement='bottom'
|
||||
*/
|
||||
placement: 'bottom',
|
||||
/**
|
||||
* Popper's placement.
|
||||
* @prop {Popper.placements} placement='bottom'
|
||||
*/
|
||||
placement: 'bottom',
|
||||
|
||||
/**
|
||||
* Set this to true if you want popper to position it self in 'fixed' mode
|
||||
* @prop {Boolean} positionFixed=false
|
||||
*/
|
||||
positionFixed: false,
|
||||
/**
|
||||
* Set this to true if you want popper to position it self in 'fixed' mode
|
||||
* @prop {Boolean} positionFixed=false
|
||||
*/
|
||||
positionFixed: false,
|
||||
|
||||
/**
|
||||
* Whether events (resize, scroll) are initially enabled.
|
||||
* @prop {Boolean} eventsEnabled=true
|
||||
*/
|
||||
eventsEnabled: true,
|
||||
/**
|
||||
* Whether events (resize, scroll) are initially enabled.
|
||||
* @prop {Boolean} eventsEnabled=true
|
||||
*/
|
||||
eventsEnabled: true,
|
||||
|
||||
/**
|
||||
* Set to true if you want to automatically remove the popper when
|
||||
* you call the `destroy` method.
|
||||
* @prop {Boolean} removeOnDestroy=false
|
||||
*/
|
||||
removeOnDestroy: false,
|
||||
/**
|
||||
* Set to true if you want to automatically remove the popper when
|
||||
* you call the `destroy` method.
|
||||
* @prop {Boolean} removeOnDestroy=false
|
||||
*/
|
||||
removeOnDestroy: false,
|
||||
|
||||
/**
|
||||
* Callback called when the popper is created.<br />
|
||||
* By default, it is set to no-op.<br />
|
||||
* Access Popper.js instance with `data.instance`.
|
||||
* @prop {onCreate}
|
||||
*/
|
||||
onCreate: () => {},
|
||||
/**
|
||||
* Callback called when the popper is created.<br />
|
||||
* By default, it is set to no-op.<br />
|
||||
* Access Popper.js instance with `data.instance`.
|
||||
* @prop {onCreate}
|
||||
*/
|
||||
onCreate: () => { },
|
||||
|
||||
/**
|
||||
* Callback called when the popper is updated. This callback is not called
|
||||
* on the initialization/creation of the popper, but only on subsequent
|
||||
* updates.<br />
|
||||
* By default, it is set to no-op.<br />
|
||||
* Access Popper.js instance with `data.instance`.
|
||||
* @prop {onUpdate}
|
||||
*/
|
||||
onUpdate: () => {},
|
||||
/**
|
||||
* Callback called when the popper is updated. This callback is not called
|
||||
* on the initialization/creation of the popper, but only on subsequent
|
||||
* updates.<br />
|
||||
* By default, it is set to no-op.<br />
|
||||
* Access Popper.js instance with `data.instance`.
|
||||
* @prop {onUpdate}
|
||||
*/
|
||||
onUpdate: () => { },
|
||||
|
||||
/**
|
||||
* List of modifiers used to modify the offsets before they are applied to the popper.
|
||||
* They provide most of the functionalities of Popper.js.
|
||||
* @prop {modifiers}
|
||||
*/
|
||||
modifiers,
|
||||
/**
|
||||
* List of modifiers used to modify the offsets before they are applied to the popper.
|
||||
* They provide most of the functionalities of Popper.js.
|
||||
* @prop {modifiers}
|
||||
*/
|
||||
modifiers,
|
||||
};
|
||||
|
||||
/**
|
||||
@@ -76,4 +76,4 @@ export default {
|
||||
/**
|
||||
* @callback onUpdate
|
||||
* @param {dataObject} data
|
||||
*/
|
||||
*/
|
||||
@@ -7,26 +7,26 @@ import getSupportedPropertyName from '../utils/getSupportedPropertyName';
|
||||
* @memberof Popper
|
||||
*/
|
||||
export default function destroy() {
|
||||
this.state.isDestroyed = true;
|
||||
this.state.isDestroyed = true;
|
||||
|
||||
// touch DOM only if `applyStyle` modifier is enabled
|
||||
if (isModifierEnabled(this.modifiers, 'applyStyle')) {
|
||||
this.popper.removeAttribute('x-placement');
|
||||
this.popper.style.position = '';
|
||||
this.popper.style.top = '';
|
||||
this.popper.style.left = '';
|
||||
this.popper.style.right = '';
|
||||
this.popper.style.bottom = '';
|
||||
this.popper.style.willChange = '';
|
||||
this.popper.style[getSupportedPropertyName('transform')] = '';
|
||||
}
|
||||
// touch DOM only if `applyStyle` modifier is enabled
|
||||
if (isModifierEnabled(this.modifiers, 'applyStyle')) {
|
||||
this.popper.removeAttribute('x-placement');
|
||||
this.popper.style.position = '';
|
||||
this.popper.style.top = '';
|
||||
this.popper.style.left = '';
|
||||
this.popper.style.right = '';
|
||||
this.popper.style.bottom = '';
|
||||
this.popper.style.willChange = '';
|
||||
this.popper.style[getSupportedPropertyName('transform')] = '';
|
||||
}
|
||||
|
||||
this.disableEventListeners();
|
||||
this.disableEventListeners();
|
||||
|
||||
// remove the popper if user explicitly asked for the deletion on destroy
|
||||
// do not use `remove` because IE11 doesn't support it
|
||||
if (this.options.removeOnDestroy) {
|
||||
this.popper.parentNode.removeChild(this.popper);
|
||||
}
|
||||
return this;
|
||||
}
|
||||
// remove the popper if user explicitly asked for the deletion on destroy
|
||||
// do not use `remove` because IE11 doesn't support it
|
||||
if (this.options.removeOnDestroy) {
|
||||
this.popper.parentNode.removeChild(this.popper);
|
||||
}
|
||||
return this;
|
||||
}
|
||||
@@ -8,8 +8,8 @@ import removeEventListeners from '../utils/removeEventListeners';
|
||||
* @memberof Popper
|
||||
*/
|
||||
export default function disableEventListeners() {
|
||||
if (this.state.eventsEnabled) {
|
||||
cancelAnimationFrame(this.scheduleUpdate);
|
||||
this.state = removeEventListeners(this.reference, this.state);
|
||||
}
|
||||
}
|
||||
if (this.state.eventsEnabled) {
|
||||
cancelAnimationFrame(this.scheduleUpdate);
|
||||
this.state = removeEventListeners(this.reference, this.state);
|
||||
}
|
||||
}
|
||||
@@ -7,12 +7,12 @@ import setupEventListeners from '../utils/setupEventListeners';
|
||||
* @memberof Popper
|
||||
*/
|
||||
export default function enableEventListeners() {
|
||||
if (!this.state.eventsEnabled) {
|
||||
this.state = setupEventListeners(
|
||||
this.reference,
|
||||
this.options,
|
||||
this.state,
|
||||
this.scheduleUpdate
|
||||
);
|
||||
}
|
||||
}
|
||||
if (!this.state.eventsEnabled) {
|
||||
this.state = setupEventListeners(
|
||||
this.reference,
|
||||
this.options,
|
||||
this.state,
|
||||
this.scheduleUpdate
|
||||
);
|
||||
}
|
||||
}
|
||||
@@ -30,19 +30,19 @@
|
||||
* @memberof Popper
|
||||
*/
|
||||
export default [
|
||||
'auto-start',
|
||||
'auto',
|
||||
'auto-end',
|
||||
'top-start',
|
||||
'top',
|
||||
'top-end',
|
||||
'right-start',
|
||||
'right',
|
||||
'right-end',
|
||||
'bottom-end',
|
||||
'bottom',
|
||||
'bottom-start',
|
||||
'left-end',
|
||||
'left',
|
||||
'left-start',
|
||||
];
|
||||
'auto-start',
|
||||
'auto',
|
||||
'auto-end',
|
||||
'top-start',
|
||||
'top',
|
||||
'top-end',
|
||||
'right-start',
|
||||
'right',
|
||||
'right-end',
|
||||
'bottom-end',
|
||||
'bottom',
|
||||
'bottom-start',
|
||||
'left-end',
|
||||
'left',
|
||||
'left-start',
|
||||
];
|
||||
@@ -11,65 +11,65 @@ import runModifiers from '../utils/runModifiers';
|
||||
* @memberof Popper
|
||||
*/
|
||||
export default function update() {
|
||||
// if popper is destroyed, don't perform any further update
|
||||
if (this.state.isDestroyed) {
|
||||
return;
|
||||
}
|
||||
// if popper is destroyed, don't perform any further update
|
||||
if (this.state.isDestroyed) {
|
||||
return;
|
||||
}
|
||||
|
||||
let data = {
|
||||
instance: this,
|
||||
styles: {},
|
||||
arrowStyles: {},
|
||||
attributes: {},
|
||||
flipped: false,
|
||||
offsets: {},
|
||||
};
|
||||
let data = {
|
||||
instance: this,
|
||||
styles: {},
|
||||
arrowStyles: {},
|
||||
attributes: {},
|
||||
flipped: false,
|
||||
offsets: {},
|
||||
};
|
||||
|
||||
// compute reference element offsets
|
||||
data.offsets.reference = getReferenceOffsets(
|
||||
this.state,
|
||||
this.popper,
|
||||
this.reference,
|
||||
this.options.positionFixed
|
||||
);
|
||||
// compute reference element offsets
|
||||
data.offsets.reference = getReferenceOffsets(
|
||||
this.state,
|
||||
this.popper,
|
||||
this.reference,
|
||||
this.options.positionFixed
|
||||
);
|
||||
|
||||
// compute auto placement, store placement inside the data object,
|
||||
// modifiers will be able to edit `placement` if needed
|
||||
// and refer to originalPlacement to know the original value
|
||||
data.placement = computeAutoPlacement(
|
||||
this.options.placement,
|
||||
data.offsets.reference,
|
||||
this.popper,
|
||||
this.reference,
|
||||
this.options.modifiers.flip.boundariesElement,
|
||||
this.options.modifiers.flip.padding
|
||||
);
|
||||
// compute auto placement, store placement inside the data object,
|
||||
// modifiers will be able to edit `placement` if needed
|
||||
// and refer to originalPlacement to know the original value
|
||||
data.placement = computeAutoPlacement(
|
||||
this.options.placement,
|
||||
data.offsets.reference,
|
||||
this.popper,
|
||||
this.reference,
|
||||
this.options.modifiers.flip.boundariesElement,
|
||||
this.options.modifiers.flip.padding
|
||||
);
|
||||
|
||||
// store the computed placement inside `originalPlacement`
|
||||
data.originalPlacement = data.placement;
|
||||
// store the computed placement inside `originalPlacement`
|
||||
data.originalPlacement = data.placement;
|
||||
|
||||
data.positionFixed = this.options.positionFixed;
|
||||
data.positionFixed = this.options.positionFixed;
|
||||
|
||||
// compute the popper offsets
|
||||
data.offsets.popper = getPopperOffsets(
|
||||
this.popper,
|
||||
data.offsets.reference,
|
||||
data.placement
|
||||
);
|
||||
// compute the popper offsets
|
||||
data.offsets.popper = getPopperOffsets(
|
||||
this.popper,
|
||||
data.offsets.reference,
|
||||
data.placement
|
||||
);
|
||||
|
||||
data.offsets.popper.position = this.options.positionFixed
|
||||
? 'fixed'
|
||||
: 'absolute';
|
||||
data.offsets.popper.position = this.options.positionFixed
|
||||
? 'fixed'
|
||||
: 'absolute';
|
||||
|
||||
// run the modifiers
|
||||
data = runModifiers(this.modifiers, data);
|
||||
// run the modifiers
|
||||
data = runModifiers(this.modifiers, data);
|
||||
|
||||
// the first `update` will call `onCreate` callback
|
||||
// the other ones will call `onUpdate` callback
|
||||
if (!this.state.isCreated) {
|
||||
this.state.isCreated = true;
|
||||
this.options.onCreate(data);
|
||||
} else {
|
||||
this.options.onUpdate(data);
|
||||
}
|
||||
}
|
||||
// the first `update` will call `onCreate` callback
|
||||
// the other ones will call `onUpdate` callback
|
||||
if (!this.state.isCreated) {
|
||||
this.state.isCreated = true;
|
||||
this.options.onCreate(data);
|
||||
} else {
|
||||
this.options.onUpdate(data);
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user