From e4ba0214821d676923ce1bc6e444e10609bd0504 Mon Sep 17 00:00:00 2001
From: "luca.mazzoleni" <luca.mazzoleni@egalware.com>
Date: Thu, 12 Dec 2024 09:26:35 +0100
Subject: [PATCH] - in LapJoint abiitata SideMillAsBlade anche da sotto

---
 LuaLibs/ProcessLapJoint.lua | 23 ++++++++++++++++++-----
 1 file changed, 18 insertions(+), 5 deletions(-)

diff --git a/LuaLibs/ProcessLapJoint.lua b/LuaLibs/ProcessLapJoint.lua
index e4f7b0f..d108d1f 100644
--- a/LuaLibs/ProcessLapJoint.lua
+++ b/LuaLibs/ProcessLapJoint.lua
@@ -873,12 +873,25 @@ function ProcessLapJoint.Classify( Proc, b3Raw)
       end
       -- se è presente il rinvio angolare con lavorazioni di tasca ed è una tasca perfettamente verticale da sotto, non ruoto
       if BD.ANG_TRASM and Proc.Fct >= 4 and not bClosedOrthoFaces then
-         local vtNBottomFace = EgtSurfTmFacetNormVersor( Proc.Id, nFacInd, GDB_ID.ROOT)
-         if AreOppositeVectorApprox( vtNBottomFace, Z_AX()) and
+         if AreOppositeVectorApprox( Proc.Face[nFacInd + 1].VtN, Z_AX()) and
             ( Proc.Fct >= 5 and ML.FindPocketing( 'Pocket_AT') or ( Proc.Fct < 5 and ML.FindPocketing( 'OpenPocket_AT'))) then
             return true, false
          end
       end
+      -- se groove da sotto e possibile fresatura tipo SideMillAsBlade non ruoto
+      if Proc.AllRightAngles and Proc.Topology == 'Groove' and not( Proc.AffectedFaces.Front or Proc.AffectedFaces.Back) and AreOppositeVectorApprox( Proc.Face[nFacInd + 1].VtN, Z_AX()) then
+         -- recupero gruppo per geometria addizionale
+         local nAddGrpId = BL.GetAddGroup( nPartId)
+         if not nAddGrpId then
+            local sErr = 'Error : missing AddGroup'
+            EgtOutLog( sErr)
+            return false, sErr
+         end
+         if VerifySideMillAsSaw( Proc, nAddGrpId, Proc.Face[nFacInd + 1].VtN, min( Proc.Face[nFacInd + 1].Height, Proc.Face[nFacInd + 1].Width) , Proc.Face[nFacInd + 1].Elevation) then
+            Proc.OkFromBottom = true
+            return true, false
+         end
+      end
       -- se scanalatura chiusa lavoro la faccia di fondo
       if Proc.Topology == 'Pocket' and ( Proc.IsParallel or Proc.AllRightAngles) and not bClosedOrthoFaces then
          nFacInd = Topology.GetFacesWithGivenAdjacencyNumber( Proc, nil, 4)[1]
@@ -6195,7 +6208,7 @@ local function MakeMoreFaces( Proc, nPhase, nRawId, nPartId, dOvmHead, bSinglePa
             if BD.ANG_TRASM and Proc.Fct >= 4 and AreOppositeVectorApprox( vtN, Z_AX()) then
                bLapJointAngTrasm = true
             -- se orientata verso il basso e non c'è testa da sotto, verifico l'alternativa
-            elseif vtN:getZ() < BD.NZ_MINA and not BD.DOWN_HEAD and nFacInd2 then
+            elseif vtN:getZ() < BD.NZ_MINA and not BD.DOWN_HEAD and nFacInd2 and not Proc.OkFromBottom then
                ptC, vtN = EgtSurfTmFacetCenter( Proc.Id, nFacInd2, GDB_ID.ROOT)
                nFacInd, nFacInd2 = nFacInd2, nFacInd
                dFacElev, dFacElev2 = dFacElev2, dFacElev
@@ -6203,7 +6216,7 @@ local function MakeMoreFaces( Proc, nPhase, nRawId, nPartId, dOvmHead, bSinglePa
             end
             -- verifico non sia orientata verso il basso o ci sia una testa dal basso o la lavorazione sia dal lato.
             local bFaceDown = ( vtN:getZ() < BD.NZ_MINA)
-            if bFaceDown and not BD.DOWN_HEAD and not BD.TURN and not bForceSideMill and not bLapJointAngTrasm then
+            if bFaceDown and not BD.DOWN_HEAD and not BD.TURN and not bForceSideMill and not bLapJointAngTrasm and not Proc.OkFromBottom then
                local sErr = 'Error : LapJoint from bottom impossible'
                EgtOutLog( sErr)
                return false, sErr
@@ -7013,7 +7026,7 @@ local function MakeLongMoreFaces( Proc, nPhase, nRawId, nPartId, dOvmHead)
    for i = 1, #vAddId do
       local b3Box = EgtGetBBoxGlob( vAddId[i], GDB_BB.STANDARD)
       local nFct = EgtSurfTmFacetCount( vAddId[i])
-      local AddProc = { Id = vAddId[i], Grp = Proc.Grp, Prc = Proc.Prc, Box = b3Box, TotBox = Proc.Box, Fct = nFct, Flg = Proc.Flg, PartId = Proc.PartId, TaskId = Proc.TaskId, FeatureId = Proc.FeatureId, IsSplittedLapJoint = true, AffectedFaces = Proc.AffectedFaces}
+      local AddProc = { Id = vAddId[i], Grp = Proc.Grp, Prc = Proc.Prc, Box = b3Box, TotBox = Proc.Box, Fct = nFct, Flg = Proc.Flg, PartId = Proc.PartId, TaskId = Proc.TaskId, FeatureId = Proc.FeatureId, IsSplittedLapJoint = true, AffectedFaces = Proc.AffectedFaces, OkFromBottom = Proc.OkFromBottom}
       Topology.Classify( AddProc, b3Raw)
       -- lasciare il false nel sesto parametro (perchè internamente viene verificato se diverso da nil)
       local bOk, sMyWarn